Skip to content

Stop hiding the column number of ESLint errors #6980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2019
Merged

Stop hiding the column number of ESLint errors #6980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f8d78d
Stop hiding the column number of ESLint errors
justingrant May 3, 2019
b849067
update snapshots for tests
justingrant May 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/react-dev-utils/formatWebpackMessages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,6 @@ function formatMessage(message) {
/SyntaxError\s+\((\d+):(\d+)\)\s*(.+?)\n/g,
`${friendlySyntaxErrorLabel} $3 ($1:$2)\n`
);
// Remove columns from ESLint formatter output (we added these for more
// accurate syntax errors)
message = message.replace(/Line (\d+):\d+:/g, 'Line $1:');
// Clean up export errors
message = message.replace(
/^.*export '(.+?)' was not found in '(.+?)'.*$/gm,
Expand Down
4 changes: 2 additions & 2 deletions test/fixtures/webpack-message-formatting/__snapshots__/index.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ Object {
Failed to compile.

./src/App.js
Line 4: 'b' is not defined no-undef
Line 4:13: 'b' is not defined no-undef

Search for the keywords to learn more about each error.

Expand All @@ -79,7 +79,7 @@ Object {
Compiled with warnings.

./src/App.js
Line 3: 'foo' is defined but never used no-unused-vars
Line 3:10: 'foo' is defined but never used no-unused-vars

Search for the keywords to learn more about each warning.
To ignore, add // eslint-disable-next-line to the line before.
Expand Down