Remove no-watch flag in favor of watchAll=false #6848
Merged
+4
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugzpodder
requested review from
amyrlam,
gaearon,
ianschmitz,
iansu,
mrmckeb,
petetnt and
Timer
as code owners
|
While this is true, I feel like having to set pass a flag as If the rest of the team are in favour of this, I think this should be in 3.0. |
mrmckeb
approved these changes
Apr 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn test --watchAll=falseornpm test -- --watchAll=falseis already sufficient for running tests in non-watch mode. Both does the same thing as the current --no-watch flag.