Skip to content

Remove duplicate url key in siteConfig #6690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2019
Merged

Remove duplicate url key in siteConfig #6690

merged 1 commit into from
Mar 21, 2019
+0 −1

Conversation

charpeni
Copy link
Contributor

url was duplicated in siteConfig.js, both were the same value, so stripping one of them.

@charpeni charpeni requested review from amyrlam and iansu as code owners March 20, 2019 14:09
@iansu iansu merged commit a1f6397 into facebook:master Mar 21, 2019
@iansu iansu added this to the 3.0 milestone Mar 21, 2019
@iansu
Copy link
Contributor

iansu commented Mar 21, 2019

Good catch. Thanks!

@charpeni charpeni deleted the patch-1 branch March 25, 2019 21:44
@lock lock bot locked and limited conversation to collaborators Mar 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amyrlam amyrlam Awaiting requested review from amyrlam

@iansu iansu Awaiting requested review from iansu

Assignees
No one assigned
Labels
CLA Signed tag: internal
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@charpeni @iansu @facebook-github-bot