Skip to content

Provide custom onError handler for http-proxy-middleware #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2016
Merged

Provide custom onError handler for http-proxy-middleware #502

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e54b8c1
Change http-proxy-middleware logLevel from silent to error
cloudmu Aug 26, 2016
b1b4b69
Merge remote-tracking branch 'upstream/master'
cloudmu Sep 3, 2016
4dd0d43
provide onError handler for httpProxyMiddleware
cloudmu Sep 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions scripts/start.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,23 @@ function openBrowser(port, protocol) {
opn(protocol + '://localhost:' + port + '/');
}

// We need to provide a custom onError function for httpProxyMiddleware.
// It allows us to log custom error messages on the console.
function onProxyError(proxy) {
return function(err, req, res){
var host = req.headers && req.headers.host;
console.log(
chalk.red('Proxy error:') + ' Could not proxy request ' + chalk.cyan(req.url) +
' from ' + chalk.cyan(host) + ' to ' + chalk.cyan(proxy) + '.'
);
console.log(
'See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (' +
chalk.cyan(err.code) + ').'
);
console.log();
}
}

function addMiddleware(devServer) {
// `proxy` lets you to specify a fallback server during development.
// Every unrecognized request will be forwarded to it.
Expand Down Expand Up @@ -209,6 +226,7 @@ function addMiddleware(devServer) {
httpProxyMiddleware(pathname => mayProxy.test(pathname), {
target: proxy,
logLevel: 'silent',
onError: onProxyError(proxy),
secure: false,
changeOrigin: true
})
Expand Down