Skip to content

Use FIPS Compliant sha256 algorithm for hashing #13318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use FIPS Compliant sha256 algorithm for hashing #13318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-dev-utils/getCSSModuleLocalIdent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ module.exports = function getLocalIdent(
// Create a hash based on a the file location and class name. Will be unique across a project, and close to globally unique.
const hash = loaderUtils.getHashDigest(
path.posix.relative(context.rootContext, context.resourcePath) + localName,
'md5',
'sha256',
'base64',
5
);
Expand Down
2 changes: 2 additions & 0 deletions packages/react-scripts/config/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,8 @@ module.exports = function (webpackEnv) {
.replace(/\\/g, '/')
: isEnvDevelopment &&
(info => path.resolve(info.absoluteResourcePath).replace(/\\/g, '/')),
// Some environments disable insecure hash functions like md4,md5
hashFunction: 'sha256',
},
cache: {
type: 'filesystem',
Expand Down
2 changes: 1 addition & 1 deletion packages/react-scripts/config/webpack/persistentCache/createEnvironmentHash.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
const { createHash } = require('crypto');

module.exports = env => {
const hash = createHash('md5');
const hash = createHash('sha256');
hash.update(JSON.stringify(env));

return hash.digest('hex');
Expand Down