Use FIPS Compliant sha256 algorithm for hashing #13318
Conversation
md5 and md4 (the webpack default) hashes are disabled on FIPS compliant systems. Additionally sha256 is less prone to collisions. See issue #11214
|
Hi @dannyfreeman! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Sorry I refuse to sign a CLA. |
Purpose
md5 and md4 (the webpack default) hashes are disabled on FIPS compliant systems.
Additionally sha256 is less prone to collisions.
See issue #11214
Verification
I verified these changes by:
npm installnpm starthttp://localhost:3000loads the react template app../packages/cra-template/template/src/App.jsand observing the changes made are reflected onhttp://localhost:3000.Additionally I ran
npm run buildbefore and after my changes were applied to see that the filenames under./build/static/jsreflect the changed hash algorithm.Output of
ls build/static/jsafternpm run buildon commit 4170341Output of
ls build/static/jsafternpm run buildon commit 0a827f6Output of
ls build/static/jsafternpm run buildon commit 4170341 (again)