[WDS] Disconnected! with option set to HTTPS

[pungggi]

I am using the new HTTPS option to test locally from https browser to https server.
the comunication between client and server works but i get an error in the browser console>

abstract-xhr.js:132 GET https://localhost/sockjs-node/info?t=1472999253306 net::ERR_CONNECTION_REFUSEDAbstractXHRObject._start @ abstract-xhr.js:132(anonymous function) @ abstract-xhr.js:21
client:70 [WDS] Disconnected!sock.onclose @ client:70EventTarget.dispatchEvent @ eventtarget.js:51(anonymous function) @ main.js:356

HMR not working.

[gaearon]

@dceddia Can I ask you to investigate this?

[dceddia]

@gaearon Taking a look...

I can reproduce it locally against 0.4.1. However, I don't see this error with 0.3.0-alpha (which is where I originally tried out this HTTPS feature and used it successfully for a couple weeks). Maybe something changed with the how socket connection works?

Edit: The difference has something to do with how that URL is determined. On the (old) version that worked, the url has the port specified, e.g. https://localhost:3000/sockjs-node/... whereas the broken one leaves out the port like https://localhost/sockjs-node/....

Maybe it's a webpack change - the broken one is running webpack-dev-server 1.15.1 while the working one is using 1.14.1...

Edit 2: Confirmed that it works with 1.14.1 but doesn't work with 1.15.1. Looking into why...

[dceddia]

It looks like it has something to do with how the webpack-dev-server client determines the URL. In v1.15.1:

https://github.com/webpack/webpack-dev-server/blob/v1.15.1/client/index.js#L62

protocol: (window.location.protocol === "https:" || urlParts.hostname === '0.0.0.0') ? window.location.protocol : urlParts.protocol,

In v1.14.1:

https://github.com/webpack/webpack-dev-server/blob/v1.14.1/client/index.js#L62

protocol: urlParts.protocol,

Changing that one line to the old protocol: urlParts.protocol fixes this issue. That's not terribly helpful for us though, since there doesn't seem to be any way to influence how that protocol is decided.

@gaearon Sorry for letting this slip through. Would you like me to file an issue with webpack-dev-server? Can you see another way around it?

[gaearon]

Please file an issue with WDS. We can release a path that rolls our version of it back if this takes time to fix.

[chall8908]

Per my comment on #263 (sorry for misposting that), I've fixed this locally by changing this line in config/webpack.config.dev.js:
require.resolve('webpack-dev-server/client') + '?/',
to
require.resolve('webpack-dev-server/client') + '?http://0.0.0.0:0/',

Based on my understanding of the WDS code, this will configure the client to use the current window's protocol, hostname, and port.

A point of interest is that I was not seeing the initial connection going through at all until I made this change. Though, afterwords, everything is working correctly.

EDIT: To clarify, by "fixed locally" I modified the config file without ejecting first. Not good practice, but I was just trying to see if I could fix it.

[dceddia]

Nice, that fixes it for me too.

I was worried that it might break hostnames other than localhost, so I tried giving my machine an alias of devtest in /etc/hosts -- everything seems to work fine. Also tested with 127.0.0.1. I can't think of any other negative side-effects this change would have, besides it feeling like a hacky workaround for a WDS bug.

I could make a PR if we want to get the fix in though, thoughts?

[gaearon]

It was 0.0.0.0 at some point but I changed it because something else broke. I don't recall what though.

[dceddia]

It looks like Webpack won't get this fix until v2 unfortunately, so maybe
we should roll back to 1.14.1 for the time being, if that's an option:
webpack/webpack-dev-server#592 (comment)

On Tuesday, September 6, 2016, Dan Abramov notifications@github.com wrote:

It was 0.0.0.0 at some point but I changed it because something else
broke. I don't recall what though.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#574 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAe3aGNsHbhkzJM6U6Et6qJUpZTo4nIEks5qnagTgaJpZM4J0jGM
.

[gaearon]

@dceddia Send a PR please?

[SpaceK33z]

Hi, webpack-dev-server maintainer here. Reverting to 1.14.1 would probably cause other issues to come up again (e.g. #134), so would probably not be worth it.

I've changed my mind about this a bit, since I don't know when v2 will get stable, and this seems to be a blocking issue for some people.

If someone wants to backport the fix to v1, I'll merge the PR and release a new version. Don't have time to do it myself currently.

PS: also said this in the ticket mentioned above, but saying it here for visibility 😄.

[SpaceK33z]

I just released webpack-dev-server@1.15.2 with the fix for this. Thanks for the help @dceddia.