State is not preserved when hot reloading

[tomduncalf]

I would expect the app state to be preserved when hot reloading occurs, but this doesn't seem to be the case – the state always resets to the initial state.

Simple reproduction test case: https://github.com/tomduncalf/create-react-app-state-hmr-bug

[tomduncalf]

Sorry, just seen #93 – does this mean React HMR is not enabled yet? Will close this issue if so

[gaearon]

Yea, no plans to enable it until it’s more stable. (Requires work both on Webpack and my side, and I didn’t have time for this yet.)

[tomduncalf]

Cool, thanks Dan. Great work on this, makes a big difference to the mental overhead of trying out a new idea or whatever...

[gaearon]

Thanks!

[tomduncalf]

Would you consider a PR to add this as an experimental feature or do you want to avoid things like that? Unfortunately no HMR means this isn't that practical for me to use on my current project, as the state is annoying to set up every time :(

[gaearon]

No, PR won’t help because, as I said, the underlying tools are not stable enough to be the default.

[tomduncalf]

Thought so – will keep an eye on the tool and hopefully at some point HMR
can become stable enough to be supported officially :)

On 2 August 2016 at 19:40, Dan Abramov notifications@github.com wrote:

No, PR won’t help because, as I said, the underlying tools are not stable
enough to be the default.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#328 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFNIlhTxtLviLveCSnsDm6sPQA5jgjK8ks5qb48cgaJpZM4Japt_
.