mpi: use boost's lockfree ringbuffer for local messaging #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also improves both small and large messages, but not as good as #382 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
==========================================
- Coverage 82.07% 81.85% -0.23%
==========================================
Files 113 115 +2
Lines 7515 7539 +24
==========================================
+ Hits 6168 6171 +3
- Misses 1347 1368 +21 ☔ View full report in Codecov by Sentry. |
csegarragonz
force-pushed
the
spinlock
branch
2 times, most recently
from
4ad82c2 to
ead631c
Compare
lgarithm
reviewed
Feb 28, 2024
| return value; | ||
| } | ||
|
|
||
| long size() |
There was a problem hiding this comment.
you can remove this method right? it's not virtual.
csegarragonz
added a commit
that referenced
this pull request
Feb 28, 2024
csegarragonz
added a commit
that referenced
this pull request
Feb 28, 2024
csegarragonz
added a commit
that referenced
this pull request
Feb 28, 2024
csegarragonz
added a commit
that referenced
this pull request
Mar 13, 2024
csegarragonz
force-pushed
the
spinlock
branch
2 times, most recently
from
a934a4e to
0b0f1b1
Compare
csegarragonz
force-pushed
the
spinlock
branch
2 times, most recently
from
7f8ecab to
8049520
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
todo: probably want to add some locking around the recv rather than just crazyily spinlock
closes #383