Fix the redis cache spec to construct the cache with the anticipated ttl #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make timeout values really really small so our test run fast :).
|
Thank you @acinader ! I missed that second arg, also the hasty TTL is much nicer for testing :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also make timeout values really really small so our test runs fast :).
hi @f0ster!
Your pr for the redis ttl had failing tests.
I couldn't spot the error, so I checked out your branch and focused on the the failing test.
You can see in this pr what the issue was, the redis cache constructor wont handle an object parameter, it is expecting two arguments.
Since I was already in there, I also switched back the Default TTL comment cause I just prefer the way it was before :) hope that's ok.
If this all looks right to you, you can merge this pull request into your repo and then you can push your master to the parse-server repo and the open PR should update. presto!