fix(vm): handle nil arguments in variadic funcs #868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update OpCall to properly handle nil values passed to variadic functions. Previously, passing nil as the last argument caused an index out of range panic, and a single nil argument was incorrectly treated as a nil slice. Added regression tests. Signed-off-by: Ville Vesilehto <[email protected]>
thevilledev
force-pushed
the
fix/issue-817
branch
from
d1e6967 to
431bcfa
Compare
antonmedv
approved these changes
Dec 4, 2025
MasonM
added a commit
to MasonM/argo-workflows
that referenced
this pull request
Dec 16, 2025
As @dmarquez-splunk discovered, the Sprig upgrade in argoproj#14307 introduced a regression when evaluating an expression that has a call to a variadic Sprig function with `nil`. This was fixed in expr-lang/expr#868, which was released as [v1.17.7](https://github.com/expr-lang/expr/releases/tag/v1.17.7). I also added a test case to prevent regressions. Signed-off-by: Mason Malone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update OpCall to properly handle nil values passed to variadic functions. Previously, passing nil as the last argument caused an index out of range panic, and a single nil argument was incorrectly treated as a nil slice. Added regression tests.
FIxes #817.