Skip to content

Conversation

dmitry-timofeev
Copy link
Contributor

@dmitry-timofeev dmitry-timofeev commented Jul 4, 2019

Overview

That allows the users to benefit from the system libsodium
whenever it is available (it always is when the app is run,
but might not be in other usages).


See: https://jira.bf.local/browse/ECR-3288

Definition of Done

  • There are no TODOs left in the code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has Javadoc
  • Method preconditions are checked and documented in the Javadoc of the method
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

@dmitry-timofeev dmitry-timofeev added the work-in-progress 👷‍♂️ Do not expect reviewers to provide any feedback on WIP PRs — please ask for it explicitly! label Jul 4, 2019
That allows the users to benefit from the system libsodium
whenever it is available (it always is when the app is run,
but might not be in other usages).
@dmitry-timofeev dmitry-timofeev force-pushed the use-system-sodium-by-default-ECR-3288 branch from 7e99bfb to 1f95371 Compare July 22, 2019 07:34
@dmitry-timofeev dmitry-timofeev removed the work-in-progress 👷‍♂️ Do not expect reviewers to provide any feedback on WIP PRs — please ask for it explicitly! label Jul 22, 2019
@dmitry-timofeev dmitry-timofeev requested review from MakarovS, bullet-tooth and vitvakatu and removed request for vitvakatu July 22, 2019 07:35
@coveralls
Copy link

coveralls commented Jul 22, 2019

Coverage Status

Coverage increased (+0.003%) to 85.675% when pulling 3eb4b3b on dmitry-timofeev:use-system-sodium-by-default-ECR-3288 into cdc4a17 on exonum:master.

@bullet-tooth
Copy link
Contributor

I believe that com.exonum.binding.common.crypto.CryptoFunctions#ed25519 javadoc should be updated as well

@dmitry-timofeev
Copy link
Contributor Author

javadoc should be updated as well

How exactly? The system library thing?

@bullet-tooth
Copy link
Contributor

bullet-tooth commented Jul 22, 2019

Something like:

  /**
   * Returns a ED25519 public-key signature system crypto function.
   * If system crypto library is not found then the bundled one is returned.
   */

@dmitry-timofeev dmitry-timofeev merged commit 73850ca into exonum:master Jul 23, 2019
@dmitry-timofeev dmitry-timofeev deleted the use-system-sodium-by-default-ECR-3288 branch July 23, 2019 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants