Add TestKit to BOM and archetype modules [ECR-3056] #989
Conversation
MakarovS
added
the
work-in-progress 👷♂️
exonum-java-binding/bom/pom.xml
Outdated
| <groupId>com.exonum.binding</groupId> | ||
| <artifactId>exonum-testkit</artifactId> | ||
| <version>${project.version}</version> | ||
| <scope>test</scope> |
There was a problem hiding this comment.
I am not sure BOM shall specify the scope. Other test-only artifacts do not.
exonum-java-binding/service-archetype/src/main/resources/archetype-resources/pom.xml
Outdated
Show resolved
Hide resolved
|
The archetype project must depend on the testkit as well (as it does on core in runtime scope), as documented in the issue. |
MakarovS
removed
the
work-in-progress 👷♂️
| <version>${maven-archetype.version}</version> | ||
| <configuration> | ||
| <properties> | ||
| <nativeLibPath>${project.parent.basedir}/core/rust/target/debug</nativeLibPath> |
There was a problem hiding this comment.
@dip56 Would you please test that release builds continue to work (we didn't use to use the native library in archetype ITs), and the generated project works with the installed app (the current 0.7.0-SNAPSHOT)?
| } | ||
|
|
||
| @Test | ||
| void testServiceInstantiation() { |
There was a problem hiding this comment.
wouldn't it be better to create a separate class with junit5 extension? Therefore we will have 2 separate tests:
- Check that the module is properly configured
- Check that
exonum-appis properly installed
There was a problem hiding this comment.
Not sure. This particular test is only useful at project initialization to verify the app is installed properly + as an example of testkit configuration 🤔 We can extend some comments here and there/modify the test display name to make their purpose more apparent.
There was a problem hiding this comment.
I removed the existing tests as they do not bring much value on top of this new one.
There was a problem hiding this comment.
and documented the likely failure
Overview
Add TestKit to BOM and archetype modules.
See: https://jira.bf.local/browse/ECR-3056
Definition of Done