Skip to content

Conversation

MakarovS
Copy link
Contributor

@MakarovS MakarovS commented Jun 5, 2019

Overview

Remove old integration tests that were replaced with TestKit tests.
In BlockchainIntegrationTest I didn't find any test cases that are not tested in new TestKit ITs. CoreSchema ITs are left as they are.


See: https://jira.bf.local/browse/ECR-3195

Definition of Done

  • There are no TODOs left in the code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has Javadoc
  • Method preconditions are checked and documented in the Javadoc of the method
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

@coveralls
Copy link

coveralls commented Jun 5, 2019

Coverage Status

Coverage decreased (-1.2%) to 85.457% when pulling 2481b21 on ECR-3195 into 22ba6d9 on master.

@dmitry-timofeev
Copy link
Contributor

Coverage is not collected accross modules, hence the drop 🤷‍♂️

Possibly, it can be reconfigured.

@dmitry-timofeev dmitry-timofeev merged commit d430654 into master Jun 5, 2019
@dmitry-timofeev dmitry-timofeev deleted the ECR-3195 branch June 5, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants