Fix warnings during the build #938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-timofeev
suggested changes
Jun 3, 2019
| <executions> | ||
| <execution> | ||
| <id>default-jar</id> | ||
| <phase/> |
There was a problem hiding this comment.
https://maven.apache.org/plugins/maven-jar-plugin/jar-mojo.html#skipIfEmpty is more appropriate
| <executions> | ||
| <execution> | ||
| <id>default-install</id> | ||
| <phase/> |
There was a problem hiding this comment.
With ^ is this configuration needed?
There was a problem hiding this comment.
If yes (= there is some other warning), there is a more appropriate https://maven.apache.org/plugins/maven-install-plugin/install-mojo.html#skip
There was a problem hiding this comment.
yes, it's required because it tries to install unexisting jar.
| </descriptorRefs> | ||
| <finalName>${project.artifactId}-${project.version}-artifact</finalName> | ||
| <appendAssemblyId>false</appendAssemblyId> | ||
| <!-- Do not use the produced artifact jar file as a main jar |
dmitry-timofeev
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixed two kinds of warnings:
[WARNING] JAR will be empty - no content was marked for inclusion!Added maven configuration to do not create a
jarfile because the module is not supposed to produce it.The reason was
assembly-pluginreplaces default jar by produced artifact-jar and installs it to the repo with default name.Definition of Done