Skip to content

Update the service API prefix [ECR-3042]: #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2019
Merged

Update the service API prefix [ECR-3042]: #826

merged 1 commit into from
Apr 8, 2019

Conversation

dmitry-timofeev
Copy link
Contributor

@dmitry-timofeev dmitry-timofeev commented Apr 8, 2019 •
edited
Loading

Overview

Change it from "/api" to "/api/services" for consistency
with Exonum Core.

Also, change service names:

  • "cryptocurrency-demo-service" -> "cryptocurrency-demo"
  • "ejb-qa-service" -> "qa"

See: https://jira.bf.local/browse/ECR-3042

Definition of Done

  • There are no TODOs left in the code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has Javadoc
  • Method preconditions are checked and documented in the Javadoc of the method
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

@dmitry-timofeev
Update the service API prefix [ECR-3042]:
c6b3a25 
Change it from "/api" to "/api/services" for consistency
with Exonum Core.

Also, change service names:
 - "cryptocurrency-demo-service" -> "cryptocurrency-demo"
 - "ejb-qa-service" -> "qa"
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.054% when pulling c6b3a25 on dmitry-timofeev:update-mount-root-ECR-3042 into 5ee9ece on exonum:master.

@dmitry-timofeev dmitry-timofeev merged commit 5ea0735 into exonum:master Apr 8, 2019
@dmitry-timofeev dmitry-timofeev deleted the update-mount-root-ECR-3042 branch April 8, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skletsun skletsun Awaiting requested review from skletsun

@ivan-ochc ivan-ochc Awaiting requested review from ivan-ochc

@vitvakatu vitvakatu Awaiting requested review from vitvakatu

3 more reviewers

@dip56 dip56 dip56 approved these changes

@bullet-tooth bullet-tooth bullet-tooth approved these changes

@MakarovS MakarovS MakarovS approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dmitry-timofeev @coveralls @dip56 @bullet-tooth @MakarovS