Skip to content

Minor EJB fixes #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 22, 2019
Merged

Minor EJB fixes #731

merged 3 commits into from
Feb 22, 2019

Conversation

MakarovS
Copy link
Contributor

@MakarovS MakarovS commented Feb 22, 2019 •
edited
Loading

Overview

Various minor changes throughout the project.

Definition of Done

  • There are no TODOs left in the code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has Javadoc
  • Method preconditions are checked and documented in the Javadoc of the method
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

@coveralls
Copy link

coveralls commented Feb 22, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.08%) to 85.448% when pulling 8fbc406 on minor-updates into 17b7cf5 on master.

dmitry-timofeev
dmitry-timofeev approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@dmitry-timofeev dmitry-timofeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pom.xml
</developer>
</developers>

<modules>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, Why do we have developers/scm/issueManagement in the parent POM if it is not published anywhere (unlike ejb-parent & light-client)? Shan't we remove that as redundant?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally @DENMROOT is not in this list 🙃

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From https://maven.apache.org/pom.html#Developers (from SO):

A good rule of thumb is, if the person should not be contacted about the project, they need not be listed here.

As we don't include emails here, this whole section does not seem to make much sense to me.

@dmitry-timofeev dmitry-timofeev merged commit 68871c8 into master Feb 22, 2019
@dmitry-timofeev dmitry-timofeev deleted the minor-updates branch February 22, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@vitvakatu vitvakatu vitvakatu left review comments

@dmitry-timofeev dmitry-timofeev dmitry-timofeev approved these changes

@bullet-tooth bullet-tooth bullet-tooth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MakarovS @coveralls @bullet-tooth @vitvakatu @dmitry-timofeev