Add Prefixed database Access [ECR-4159]: #1382
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the AbstractAccess to resolve addresses into numeric ids and then use the ids to cache indexes. That is required for correct operation of Prefixed accesses and will be fully tested when they are added. This patch requires the native code for operation, and currently does not pass tests.
Add the Prefixed access, that can be created either from a handle, or from the base access and the namespace. Clarify IndexAddress documentation and StorageIndex spec, to allow index pooling across Accesses.
dmitry-timofeev
force-pushed
the
add-prefixed-access-ECR-4159
branch
from
03b7a21 to
f2b40a6
Compare
dmitry-timofeev
changed the title
vitvakatu
reviewed
Jan 28, 2020
| * Creates a Prefixed native peer given the base access native handle. | ||
| * @throws RuntimeException if the base access is unsupported; or if the namespace is not valid | ||
| */ | ||
| private static native long nativeCreate(String namespace, long accessNativeHandle); |
There was a problem hiding this comment.
nit: we usually use (handle, arguments....) order in native methods
There was a problem hiding this comment.
In create* a handle is just an argument, it is not a handle to "this".
There was a problem hiding this comment.
Okay, I guess it's the matter of taste
bullet-tooth
approved these changes
Jan 28, 2020
| @AfterEach | ||
| void dropDatabase() throws CloseFailuresException { | ||
| try { | ||
| cleaner.close(); |
There was a problem hiding this comment.
NPE if an exception occurs in creating db 🙃
dmitry-timofeev
changed the base branch from
use-numeric-index-id-ECR-4156
to
numeric-index-ids-for-cache
dmitry-timofeev
added a commit
that referenced
this pull request
Jan 29, 2020
dmitry-timofeev
added a commit
that referenced
this pull request
Jan 29, 2020
dmitry-timofeev
force-pushed
the
numeric-index-ids-for-cache
branch
from
ed40b4f to
d5daac9
Compare
dmitry-timofeev
added a commit
that referenced
this pull request
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add the Prefixed access, that can be created either
from a handle, or from the base access and the namespace.
Clarify IndexAddress documentation and StorageIndex spec,
to allow index pooling across Accesses.
See: https://jira.bf.local/browse/ECR-4159
Definition of Done