Skip to content

Conversation

bullet-tooth
Copy link
Contributor

Overview


See: https://jira.bf.local/browse/ECR-4083

Add migration from long to int for:

  • tx_position
  • index_in_block

Definition of Done

  • There are no TODOs left in the code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has Javadoc
  • Method preconditions are checked and documented in the Javadoc of the method
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

Copy link
Contributor

@dmitry-timofeev dmitry-timofeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but why does it target ecr-4021 and not master? Where the native will be updated to the appropriate revision?

@bullet-tooth bullet-tooth changed the base branch from ecr-4021 to new-protos-base January 8, 2020 15:47
@bullet-tooth bullet-tooth changed the base branch from new-protos-base to ecr-4021 January 8, 2020 15:47
@bullet-tooth
Copy link
Contributor Author

@dmitry-timofeev we agreed with @vitvakatu that we'll create a new base branch for reflection all required changes there. So I will re-create a new PR with new base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants