Skip to content

Fix licenses generation [ECR-4001] [ECR-3968] #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2019
Merged

Fix licenses generation [ECR-4001] [ECR-3968] #1305

merged 1 commit into from
Dec 18, 2019

Conversation

vitvakatu
Copy link
Contributor

Overview

Cargo-licesense 0.3.0 offers a pretty --json option which solves our formatting issues.
Also fixes output directory and now native licenses file is correctly packaged. (Why haven't we checked it before?)

See: https://jira.bf.local/browse/ECR-4001
See: https://jira.bf.local/browse/ECR-3968

Definition of Done

  • There are no TODOs left in the code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has Javadoc
  • Method preconditions are checked and documented in the Javadoc of the method
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

Fix native licenses generation and packaging
a367b48 
Now native licenses are correctly packaged
Now native licenses are in JSON format
dmitry-timofeev
dmitry-timofeev approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@dmitry-timofeev dmitry-timofeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can post-process JSON into some more readable format later.

@dmitry-timofeev dmitry-timofeev merged commit 91491fd into exonum:ejb/v0.9.0-rc2-release Dec 18, 2019
dmitry-timofeev pushed a commit that referenced this pull request Dec 18, 2019
@dmitry-timofeev
Fix native licenses generation and packaging [ECR-4001] [ECR-3968] (#…
633bd38 
…1305)

Now native licenses are correctly packaged
Now native licenses are in JSON format
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.397% when pulling a367b48 on vitvakatu:ecr-4001-fix-licenses-generation into b6e50ca on exonum:ejb/v0.9.0-rc2-release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dmitry-timofeev dmitry-timofeev dmitry-timofeev approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitvakatu @coveralls @dmitry-timofeev