Skip to content

Conversation

vitvakatu
Copy link
Contributor

Overview


See: https://jira.bf.local/browse/ECR-XYZ

Definition of Done

  • There are no TODOs left in the code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has Javadoc
  • Method preconditions are checked and documented in the Javadoc of the method
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

Copy link
Contributor

@dmitry-timofeev dmitry-timofeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ivan-ochc It won't hurt, but the system tests use their own config, don't they?

@dmitry-timofeev dmitry-timofeev merged commit 5b510f1 into exonum:ejb/v0.9.0-rc1-release Dec 12, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.397% when pulling f684b71 on vitvakatu:fix-qa-service-config into e763820 on exonum:ejb/v0.9.0-rc1-release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants