Skip to content

Conversation

dmitry-timofeev
Copy link
Contributor

Overview

Extract these operations to the interface. Move their tests
to the base test of interface operations, make some of them
parameterized.


See: https://jira.bf.local/browse/ECR-3669

Definition of Done

  • There are no TODOs left in the code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has Javadoc
  • Method preconditions are checked and documented in the Javadoc of the method
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

Extract these operations to the interface. Move their tests
to the base test of interface operations, make some of them
parameterized.
@coveralls
Copy link

coveralls commented Dec 6, 2019

Coverage Status

Coverage remained the same at 85.735% when pulling 5bbfa2d on dmitry-timofeev:truncate-pop-ECR-3669 into a5cc533 on exonum:master.

Copy link
Contributor

@MakarovS MakarovS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dmitry-timofeev dmitry-timofeev merged commit 82bcc37 into exonum:master Dec 10, 2019
@dmitry-timofeev dmitry-timofeev deleted the truncate-pop-ECR-3669 branch December 10, 2019 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants