Skip to content

Make QA service configurable [ECR-3869] #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 3, 2019
Merged

Make QA service configurable [ECR-3869] #1237

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
015d820
WIP Make QA service configurable [ECR-3869]
dmitry-timofeev Nov 22, 2019
28e1862
Revert the test:
dmitry-timofeev Nov 25, 2019
8b060a9
Rename the config message to QaConfiguration
dmitry-timofeev Dec 3, 2019
fccd484
Merge remote-tracking branch 'main/master' into make-qa-service-confi…
dmitry-timofeev Dec 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion exonum-java-binding/qa-service/src/main/java/com/exonum/binding/qaservice/QaService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import com.exonum.binding.common.crypto.PublicKey;
import com.exonum.binding.common.hash.HashCode;
import com.exonum.binding.core.service.Configurable;
import com.exonum.binding.core.service.Node;
import com.exonum.binding.core.service.Service;
import com.exonum.binding.core.transaction.RawTransaction;
Expand All @@ -29,7 +30,7 @@
/**
* A simple service for QA purposes.
*/
public interface QaService extends Service {
public interface QaService extends Service, Configurable {

/**
* Creates a new self-signed 'increment counter' transaction and submits
Expand Down
49 changes: 34 additions & 15 deletions exonum-java-binding/qa-service/src/main/java/com/exonum/binding/qaservice/QaServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ public List<HashCode> getStateHashes(Snapshot snapshot) {
@Override
public void initialize(Fork fork, Configuration configuration) {
// Init the time oracle
initTimeOracle(fork, configuration);
updateTimeOracle(fork, configuration);

// Add a default counter to the blockchain.
createCounter(DEFAULT_COUNTER_NAME, fork);
Expand All @@ -110,20 +110,6 @@ public void initialize(Fork fork, Configuration configuration) {
createCounter(AFTER_COMMIT_COUNTER_NAME, fork);
}

private void initTimeOracle(Fork fork, Configuration configuration) {
QaSchema schema = createDataSchema(fork);
InitialConfiguration config = configuration.getAsMessage(InitialConfiguration.class);
String timeOracleName = config.getTimeOracleName();
// Check the time oracle name is non-empty.
// We do *not* check if the time oracle is active to (a) allow running this service with
// reduced read functionality without time oracle; (b) testing time schema when it is not
// active.
checkArgument(!Strings.isNullOrEmpty(timeOracleName), "Empty time oracle name: %s",
timeOracleName);
// Save the configuration
schema.timeOracleName().set(timeOracleName);
}

private void createCounter(String name, Fork fork) {
QaSchema schema = createDataSchema(fork);
MapIndex<HashCode, Long> counters = schema.counters();
Expand Down Expand Up @@ -231,4 +217,37 @@ private HashCode submitTransaction(RawTransaction rawTransaction) {
private void checkBlockchainInitialized() {
checkState(node != null, "Service has not been fully initialized yet");
}

@Override
public void verifyConfiguration(Fork fork, Configuration configuration) {
InitialConfiguration config = configuration.getAsMessage(InitialConfiguration.class);
checkConfiguration(config);
}

@Override
public void applyConfiguration(Fork fork, Configuration configuration) {
updateTimeOracle(fork, configuration);
}

private void checkConfiguration(InitialConfiguration config) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we rename InitialConfiguration if it's not necessarily initial?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good observation, thanks, let it be QaConfiguration.

(@ivan-ochc — see the patches to the specification: https://wiki.bf.local/pages/viewpreviousversions.action?pageId=1710016)

String timeOracleName = config.getTimeOracleName();
// Check the time oracle name is non-empty.
// We do *not* check if the time oracle is active to (a) allow running this service with
// reduced read functionality without time oracle; (b) testing time schema when it is not
// active.
checkArgument(!Strings.isNullOrEmpty(timeOracleName), "Empty time oracle name: %s",
timeOracleName);
}

private void updateTimeOracle(Fork fork, Configuration configuration) {
QaSchema schema = createDataSchema(fork);
InitialConfiguration config = configuration.getAsMessage(InitialConfiguration.class);

// Verify the configuration
checkConfiguration(config);

// Save the configuration
String timeOracleName = config.getTimeOracleName();
schema.timeOracleName().set(timeOracleName);
}
}