Remove Transaction#info: [ECR-3793] #1225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MakarovS
approved these changes
Nov 14, 2019
| * | ||
| * <p>Such transaction is supposed to be used in TransactionProxy integration tests. | ||
| */ | ||
| public final class SetEntryTransaction implements Transaction { |
There was a problem hiding this comment.
Why did you remove the whole transaction and not just info()?
There was a problem hiding this comment.
It used to be used in native ITs of Rust TransactionProxy, which are gone. Probably, most of fakes will be gone, but that's after @ipenkin 's tests.
This operation is no longer used by the framework.
dmitry-timofeev
force-pushed
the
remove-tx-info
branch
from
02a6fd6 to
622537f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This operation is no longer used by the framework.
See: https://jira.bf.local/browse/ECR-3793
Definition of Done