Updated how transaction result is represented [ECR-3693] #1174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP: - Review and update docs, if needed - Unexpected exception handling — submit Jira? - Migrate to correct ExecutionStatus and remove redundant .proto in core.
dmitry-timofeev
added
the
work-in-progress 👷♂️
MakarovS
approved these changes
Oct 23, 2019
...binding/common/src/test/java/com/exonum/binding/common/blockchain/ExecutionStatusesTest.java
Outdated
Show resolved
Hide resolved
| return ImmutableList.of( | ||
| arguments(0, "Min error code"), | ||
| arguments(1, ""), | ||
| arguments(Integer.MAX_VALUE, "Max error code") |
There was a problem hiding this comment.
Did core remove 255 as maximum error code? Can't find such a restriction in native anymore.
There was a problem hiding this comment.
Actually, it is still there, as Service error variant accepts only u8 as a code.
# Conflicts: # exonum-java-binding/common/src/main/java/com/exonum/binding/common/blockchain/TransactionResult.java # exonum-java-binding/common/src/main/proto/runtime.proto # exonum-java-binding/core/src/main/proto/blockchain.proto
bullet-tooth
approved these changes
Oct 28, 2019
Also, update Exonum to 7404bac to match the source of protos
dmitry-timofeev
removed
the
work-in-progress 👷♂️
7 tasks
dmitry-timofeev
pushed a commit
that referenced
this pull request
Nov 8, 2019
Enabled TestKit tests that depended on transaction results update (#1174).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updated how transaction result is represented. This PR uses an alternative format with an enum to represent the error kind, yet to be done in the core (ECR-3717).
Dropped the internal type representing the transaction result. It has both pros and cons:
See: ECR-3693
Definition of Done