Skip to content

Conversation

vitvakatu
Copy link
Contributor

Overview


See: https://jira.bf.local/browse/ECR-XYZ

Definition of Done

  • There are no TODOs left in the code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has Javadoc
  • Method preconditions are checked and documented in the Javadoc of the method
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes

@skletsun skletsun merged commit ccd69ae into exonum:ejb/v0.8.0-release Sep 6, 2019

### Overview

This release brings mainly internal fixes and improvements. It is based on Exonum 0.12.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for late review, this was merged before I had a chance to look at it - but shouldn't we mention MerkleDb support here? Or does it fall under "internal fixes" from user's point of view and mention of Exonum 0.12 is sufficient?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it, but it turns out that these changes are internal, there is no difference from the user's point of view (yet). We didn't move to MerkleDB, we just moved to Exonum 0.12 which (accidentally) has MerkleDB as one of the components.

So I think we should not mention that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants