Use static rocksdb linkage on Mac [ECR-3324] #1011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitvakatu
added
the
work-in-progress 👷♂️
dmitry-timofeev
approved these changes
Jul 15, 2019
vitvakatu
removed
the
work-in-progress 👷♂️
vitvakatu
changed the title
| # which is not available via Homebrew | ||
| export ROCKSDB_STATIC=1 | ||
| # Check if ROCKSDB_LIB_DIR is set | ||
| if [ -z "${ROCKSDB_LIB_DIR:-}" ]; then |
There was a problem hiding this comment.
why do we need these variables? It's always the same /usr/local/lib. Can we set them here instead of requiring that from users?
There was a problem hiding this comment.
We're not requiring this from users, because our users will use the Homebrew package 😉
Setting this variable explicitly will allow you to choose what RocksDB version to use. Besides, it is also mentioned in Exonum install guide
There was a problem hiding this comment.
Mb it'll be better to replace by the following (in pseudo-code):
export ROCKSDB_LIB_DIR={ROCKSDB_LIB_DIR:-/usr/local/lib}
IF $ROCKSDB_LIB_DIR/librocksdb.dylib not found THEN fail(RocksDB not installed)
There was a problem hiding this comment.
actually, you can use a specific version of the rocksdb and use general path for snappy:
export ROCKSDB_LIB_DIR=/usr/local/Cellar/rocksdb/6.1.2/lib
or
export ROCKSDB_LIB_DIR=/usr/local/Cellar/rocksdb5/5.18.3/lib
and
export SNAPPY_LIB_DIR=/usr/local/lib
dip56
approved these changes
Jul 16, 2019
skletsun
approved these changes
Jul 16, 2019
dmitry-timofeev
approved these changes
Jul 16, 2019
|
Rocksdb 6 is fine. |
dmitry-timofeev
pushed a commit
that referenced
this pull request
Jul 16, 2019
RocksDB is linked statically on Mac to avoid problems with dynamic library resolving. When dynamic linking is currently used, the app has a dependency on a particular version of the library, with any new version breaking the installation. It is required to set ROCKSDB_LIB_DIR prior to running package_app.sh. (cherry picked from commit ae4593c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
RocksDB is linked statically on Mac to avoid problems with dynamic library resolving.. It is required to set
ROCKSDB_LIB_DIRprior to runningpackage_app.sh.See: https://jira.bf.local/browse/ECR-3324
Definition of Done