Skip to content
This repository was archived by the owner on Jul 30, 2024. It is now read-only.

"option" objects should extend js.Object & ClusterSettings.serialization should be optional #281

Merged
merged 4 commits into from
Jun 23, 2020
Merged

"option" objects should extend js.Object & ClusterSettings.serialization should be optional #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23335e0
Those should extend js.Object
exoego Jun 21, 2020
a294eb4
this parameter is optional
exoego Jun 21, 2020
9553b42
Update factory macro
exoego Jun 21, 2020
389745e
Update macro lib to not get warned on traits extending js.object thro…
exoego Jun 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/nodejs-v14/src/main/scala/io/scalajs/nodejs/child_process/SpawnSyncResult.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import scala.scalajs.js
import scala.scalajs.js.|

@Factory
trait SpawnSyncResult {
trait SpawnSyncResult extends js.Object {
var pid: Int
var output: js.Array[Output]
var stdout: Output
Expand Down
2 changes: 1 addition & 1 deletion app/nodejs-v14/src/main/scala/io/scalajs/nodejs/cluster/ClusterSettings.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ trait ClusterSettings extends js.Object {
* From Node.js v13.2.0, v12.16.0.
*/
@enableIf(io.scalajs.nodejs.internal.CompilerSwitches.gteNodeJs12)
var serialization: String = js.native
var serialization: js.UndefOr[String] = js.native

/** <Number> Sets the user identity of the process. (See setuid(2).) */
var uid: UID = js.native
Expand Down
2 changes: 1 addition & 1 deletion app/nodejs-v14/src/main/scala/io/scalajs/nodejs/crypto/DiffieHellmanOptions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import scala.scalajs.js
import net.exoego.scalajs.types.util.Factory

@Factory
trait DiffieHellmanOptions {
trait DiffieHellmanOptions extends js.Object {
var privateKey: KeyObject
var publicKey: KeyObject
}
4 changes: 2 additions & 2 deletions app/nodejs-v14/src/main/scala/io/scalajs/nodejs/fs/Fs.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1332,7 +1332,7 @@ trait FileAppendOptions extends js.Object {
}

@Factory
trait FileEncodingOptions {
trait FileEncodingOptions extends js.Object {
var encoding: js.UndefOr[String] = js.undefined
}

Expand Down Expand Up @@ -1400,7 +1400,7 @@ trait FileWatcherOptions extends js.Object {
}

@Factory
trait StatOptions {
trait StatOptions extends js.Object {
var bigint: js.UndefOr[Boolean] = js.undefined
}

Expand Down
2 changes: 1 addition & 1 deletion app/nodejs-v14/src/main/scala/io/scalajs/nodejs/vm/VM.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ trait VM extends js.Object {
object VM extends VM

@Factory
trait CompileFunctionOptions {
trait CompileFunctionOptions extends js.Object {
var filename: js.UndefOr[String] = js.undefined
var lineOffset: js.UndefOr[Int] = js.undefined
var columnOffset: js.UndefOr[Int] = js.undefined
Expand Down
2 changes: 1 addition & 1 deletion project/Dependencies.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ object Dependencies {
val app = Def.setting(
Seq(
scalaReflect.value,
"net.exoego" %%% "scalajs-types-util" % "0.1.0",
"net.exoego" %%% "scalajs-types-util" % "0.2.1",
"org.scalatest" %%% "scalatest" % scalatestVersion % "test",
"com.thoughtworks.enableIf" %% "enableif" % "1.1.7"
)
Expand Down