Skip to content
This repository was archived by the owner on Jul 30, 2024. It is now read-only.

[fs] WriteStream wrongly imports ReadStream #248

Merged
merged 2 commits into from
May 29, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,17 @@ class FsClassesTest extends AnyFunSpec {

describe("ReadStream") {
it("supports constructor(") {
assert(new ReadStream("package.json") !== null)
assert(new ReadStream("package.json").readableLength === 0)
assert(new ReadStream(Buffer.from("package.json")) !== null)
assert(new ReadStream(new URL(s"file:///${dirname}/package.json")) !== null)
}
}

describe("WriteStream") {
it("supports constructor") {
assert(new WriteStream("package.json") !== null)
assert(new WriteStream(Buffer.from("package.json")) !== null)
assert(new WriteStream(new URL(s"file:///${dirname}/package.json")) !== null)
assert(new WriteStream("NO_SUCH_FILE").writableLength === 0)
Copy link
Owner Author

@exoego exoego May 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note) Opening with correct WriteStream empty its file, so changed the file to be opened.

assert(new WriteStream(Buffer.from("NO_SUCH_FILE")) !== null)
assert(new WriteStream(new URL(s"file:///${dirname}/NO_SUCH_FILE")) !== null)
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import scala.scalajs.js.|
* @see https://nodejs.org/api/fs.html#fs_class_fs_writestream
*/
@js.native
@JSImport("fs", "ReadStream")
@JSImport("fs", "WriteStream")
class WriteStream(path: Path) extends stream.Writable {
/////////////////////////////////////////////////////////////////////////////////
// Properties
Expand Down