Skip to content
This repository was archived by the owner on Jul 30, 2024. It is now read-only.

Those modules do not extend EventEmitter actually #168

Merged
merged 1 commit into from
Feb 22, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions app/current/src/main/scala/io/scalajs/nodejs/Assert.scala
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package io.scalajs.nodejs

import io.scalajs.nodejs.events.IEventEmitter

import scala.scalajs.js
import scala.scalajs.js.annotation.JSImport
import scala.scalajs.js.|
Expand All @@ -15,7 +13,7 @@ import scala.scalajs.js.|
* methods implemented and exposed by the module.
*/
@js.native
trait Assert extends IEventEmitter {
trait Assert extends js.Object {

/**
* An alias of assert.ok() .
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ trait IEventEmitter extends js.Object {
*/
@js.native
@JSImport("events", JSImport.Namespace)
object EventEmitter extends IEventEmitter {
object EventEmitter extends js.Object {

/**
* By default, a maximum of 10 listeners can be registered for any single event. This limit can be changed
Expand Down
3 changes: 1 addition & 2 deletions app/current/src/main/scala/io/scalajs/nodejs/fs/Fs.scala
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package fs

import com.thoughtworks.{enableIf, enableMembersIf}
import io.scalajs.nodejs.buffer.Buffer
import io.scalajs.nodejs.events.IEventEmitter

import scala.scalajs.js
import scala.scalajs.js.annotation.JSImport
Expand All @@ -22,7 +21,7 @@ import scala.scalajs.js.|
* or allow them to bubble up.
*/
@js.native
trait Fs extends IEventEmitter with FSConstants {
trait Fs extends js.Object with FSConstants {

/**
* Returns an object containing commonly used constants for file system operations
Expand Down
4 changes: 1 addition & 3 deletions app/current/src/main/scala/io/scalajs/nodejs/net/Net.scala
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package io.scalajs.nodejs.net

import io.scalajs.nodejs.events.IEventEmitter

import scala.scalajs.js
import scala.scalajs.js.annotation.JSImport

Expand All @@ -11,7 +9,7 @@ import scala.scalajs.js.annotation.JSImport
* @see https://nodejs.org/api/net.html
*/
@js.native
trait Net extends IEventEmitter {
trait Net extends js.Object {
/////////////////////////////////////////////////////////////////////////////////
// Methods
/////////////////////////////////////////////////////////////////////////////////
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package io.scalajs.nodejs.readline

import io.scalajs.nodejs.events.IEventEmitter
import io.scalajs.nodejs.stream.{IReadable, IWritable}

import scala.scalajs.js
Expand All @@ -13,7 +12,7 @@ import scala.scalajs.js.annotation.JSImport
* @see https://nodejs.org/api/readline.html
*/
@js.native
trait Readline extends IEventEmitter {
trait Readline extends js.Object {

/**
* Clears current line of given TTY stream in a specified direction. <tt>dir</tt> should have one of following values:
Expand Down
3 changes: 1 addition & 2 deletions app/current/src/main/scala/io/scalajs/nodejs/repl/REPL.scala
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package io.scalajs.nodejs.repl

import io.scalajs.nodejs.events.IEventEmitter
import io.scalajs.nodejs.stream

import scala.scalajs.js
Expand All @@ -12,7 +11,7 @@ import scala.scalajs.js.annotation.JSImport
* @see https://nodejs.org/api/repl.html#repl_repl
*/
@js.native
trait REPL extends IEventEmitter {
trait REPL extends js.Object {
var REPL_MODE_SLOPPY: js.Symbol = js.native
var REPL_MODE_STRICT: js.Symbol = js.native

Expand Down
4 changes: 1 addition & 3 deletions app/current/src/main/scala/io/scalajs/nodejs/url/URL.scala
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package io.scalajs.nodejs
package url

import io.scalajs.nodejs.events.IEventEmitter

import scala.scalajs.js
import scala.scalajs.js.annotation.JSImport
import scala.scalajs.js.|
Expand Down Expand Up @@ -107,7 +105,7 @@ class URL(input: String, base: String | URL = js.native) extends js.Object {
*/
@js.native
@JSImport("url", JSImport.Namespace)
object URL extends IEventEmitter {
object URL extends js.Object {

/**
* Take a parsed URL object, and return a formatted URL string.
Expand Down
3 changes: 1 addition & 2 deletions app/current/src/main/scala/io/scalajs/nodejs/zlib/Zlib.scala
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package io.scalajs.nodejs.zlib

import com.thoughtworks.enableIf
import io.scalajs.nodejs.events.IEventEmitter

import scala.scalajs.js
import scala.scalajs.js.annotation.JSImport
Expand All @@ -12,7 +11,7 @@ import scala.scalajs.js.annotation.JSImport
* @see https://nodejs.org/docs/latest/api/zlib.html
*/
@js.native
trait Zlib extends IEventEmitter with UncategorizedConstants with ZlibConstants {
trait Zlib extends js.Object with UncategorizedConstants with ZlibConstants {
@enableIf(io.scalajs.nodejs.internal.CompilerSwitches.gteNodeJs12)
def createBrotliCompress(options: BrotliOptions = js.native): BrotliCompress = js.native

Expand Down