Skip to content
This repository was archived by the owner on Jul 30, 2024. It is now read-only.

Fix #110: setReadableEncoding should be readableEncoding #141

Merged
merged 1 commit into from
Jan 1, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,13 @@ sealed trait IReadable extends LegacyStream {
def readable: Boolean = js.native

@enableIf(io.scalajs.nodejs.internal.CompilerSwitches.gteNodeJs12)
@deprecated("Wrong name. Use readableEncoding", "0.9.1")
@JSName("readableEncoding")
def setReadableEncoding: String = js.native

@enableIf(io.scalajs.nodejs.internal.CompilerSwitches.gteNodeJs12)
def readableEncoding: String = js.native

@enableIf(io.scalajs.nodejs.internal.CompilerSwitches.gteNodeJs12)
def readableEnded: Boolean = js.native

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package io.scalajs.nodejs.stream

import io.scalajs.nodejs.fs.ReadStream
import org.scalatest.funspec.AnyFunSpec

class ReadableTest extends AnyFunSpec {
describe("Readable") {
it("readableEncoding") {
assert(new ReadStream("package.json").readableEncoding === null)
}
}
}