Skip to content

Conversation

pedrorolo
Copy link
Contributor

Adds a test to grade-school testing that a Student cannot belong in two different grades. Following up the discussion on Issue #361.

@pedrorolo
Copy link
Contributor Author

I've also created a PR on the problems-specifications track.

@glennj
Copy link

glennj commented Dec 11, 2020

Does the example solution pass this test? If not, this PR should update the example.

@pedrorolo pedrorolo force-pushed the grade-school-new-test-only-one-grade-per-student-because-student-names-are-unique branch from 0fa70b4 to aa81bb5 Compare December 11, 2020 20:44
@pedrorolo
Copy link
Contributor Author

Does the example solution pass this test? If not, this PR should update the example.

It was not passing. I've updated the example and squashed these additions into the PR branch. The updated example is the solution I developed for the exercise when I stumbled upon this issue.

Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for entertaining the conversation about this and making the necessary changes @pedrorolo

@SleeplessByte SleeplessByte merged commit f2b2630 into exercism:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants