Skip to content

Conversation

@pranasziaukas
Copy link
Contributor

Addressing the following:

  • Spacing in tests for chaitanas-colossal-coaster is inconsistent.
  • Indentation trips some pyton linters (e.g. Flake8 E128).

@pranasziaukas pranasziaukas changed the title Improve test spacing/ in chaitanas-colossal-coaster Improve test spacing in chaitanas-colossal-coaster Oct 15, 2021
@BethanyG
Copy link
Member

Hi @pranasziaukas
-- I agree that this test file needs work (thank you for submitting this), but you didn't quite go far enough. 😄

Suggest pulling the msg out into its own line so that you can avoid breaks within the assert method.
Breaks within the assert sometimes get truncated in the JSON report that gets sent to the website and cause display issues, so its best if we can fit it on one line. I think the Card Games has an example.

Additionally, if you look at PR #2660 .. we have new contributing and code style guidelines. So our line length will be 120 characters. You can download our .flake8, pylintrc and .style.yapf files here in the repo.

@pranasziaukas pranasziaukas force-pushed the chaitanas-test-styling branch from 38ec76b to e8352d9 Compare October 15, 2021 14:48
@pranasziaukas
Copy link
Contributor Author

You got me @BethanyG. I've now done a bigger refactor using self.subTest & co.

@BethanyG BethanyG added the x:size/large Large amount of work label Oct 15, 2021
Copy link
Member

@BethanyG BethanyG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pranasziaukas - I know that must have been painful, but ... its beautiful now! 🌟

Of course, my fingers are twitching to add additional test cases for those last two tasks...... 😉
Our work of improving is never done.....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:size/large Large amount of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants