Skip to content

triangle: adding a new scalene test for two smaller sides equal #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 7, 2019
Merged

triangle: adding a new scalene test for two smaller sides equal #1894

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a03cf0d
add parentheses to method area_code
YuriyCherniy May 21, 2019
9aee807
Merge pull request #1 from exercism/master
YuriyCherniy Aug 6, 2019
fcc5afc
Adding a new test and renaming another test.
YuriyCherniy Aug 7, 2019
4b10dc0
Merge pull request #2 from exercism/master
YuriyCherniy Aug 7, 2019
22a1b42
Update phone_number_test.py
YuriyCherniy Aug 7, 2019
3b6596c
Update exercises/triangle/triangle_test.py
YuriyCherniy Aug 7, 2019
ec9b0e5
edit function name
YuriyCherniy Aug 7, 2019
e64384f
Merge branch 'master' into master
YuriyCherniy Aug 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions exercises/triangle/triangle_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,11 @@ def test_all_sides_are_equal(self):
def test_two_sides_are_equal(self):
self.assertIs(scalene([4, 4, 3]), False)

# Additional tests for this track

def test_two_sides_are_equal_and_third_side_is_larger(self):
self.assertIs(scalene([3, 3, 4]), False)

def test_may_not_violate_triangle_inequality(self):
self.assertIs(scalene([7, 3, 2]), False)

Expand Down