Skip to content

kindergarten-garden: Completionist #1744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2020
Merged

kindergarten-garden: Completionist #1744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
191 changes: 178 additions & 13 deletions exercises/kindergarten-garden/canonical-data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,12 @@
"diagram": "RC\nGG",
"student": "Alice"
},
"expected": ["radishes", "clover", "grass", "grass"]
"expected": [
"radishes",
"clover",
"grass",
"grass"
]
},
{
"uuid": "acd19dc1-2200-4317-bc2a-08f021276b40",
Expand All @@ -22,7 +27,12 @@
"diagram": "VC\nRC",
"student": "Alice"
},
"expected": ["violets", "clover", "radishes", "clover"]
"expected": [
"violets",
"clover",
"radishes",
"clover"
]
},
{
"uuid": "c376fcc8-349c-446c-94b0-903947315757",
Expand All @@ -32,7 +42,12 @@
"diagram": "VVCG\nVVRC",
"student": "Bob"
},
"expected": ["clover", "grass", "radishes", "clover"]
"expected": [
"clover",
"grass",
"radishes",
"clover"
]
},
{
"description": "multiple students for the same garden with three students",
Expand All @@ -45,7 +60,12 @@
"diagram": "VVCCGG\nVVCCGG",
"student": "Bob"
},
"expected": ["clover", "clover", "clover", "clover"]
"expected": [
"clover",
"clover",
"clover",
"clover"
]
},
{
"uuid": "57712331-4896-4364-89f8-576421d69c44",
Expand All @@ -55,7 +75,12 @@
"diagram": "VVCCGG\nVVCCGG",
"student": "Charlie"
},
"expected": ["grass", "grass", "grass", "grass"]
"expected": [
"grass",
"grass",
"grass",
"grass"
]
}
]
}
Expand All @@ -66,43 +91,183 @@
"cases": [
{
"uuid": "149b4290-58e1-40f2-8ae4-8b87c46e765b",
"description": "first student's garden",
"description": "for Alice, first student's garden",
Copy link
Member

@ErikSchierboom ErikSchierboom Dec 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we said that changing the description was a breaking change. I'm not totally sure though. Might be up for discussion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think description is mutable as long as it clarifies or fixes typos. Which this does.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I think we forgot to document this :D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We forgot to document this, but I remembered 🥇

"property": "plants",
"input": {
"diagram": "VRCGVVRVCGGCCGVRGCVCGCGV\nVRCCCGCRRGVCGCRVVCVGCGCV",
"student": "Alice"
},
"expected": ["violets", "radishes", "violets", "radishes"]
"expected": [
"violets",
"radishes",
"violets",
"radishes"
]
},
{
"uuid": "ba25dbbc-10bd-4a37-b18e-f89ecd098a5e",
"description": "second student's garden",
"description": "for Bob, second student's garden",
"property": "plants",
"input": {
"diagram": "VRCGVVRVCGGCCGVRGCVCGCGV\nVRCCCGCRRGVCGCRVVCVGCGCV",
"student": "Bob"
},
"expected": ["clover", "grass", "clover", "clover"]
"expected": [
"clover",
"grass",
"clover",
"clover"
]
},
{
"uuid": "566b621b-f18e-4c5f-873e-be30544b838c",
"description": "for Charlie",
"property": "plants",
"input": {
"diagram": "VRCGVVRVCGGCCGVRGCVCGCGV\nVRCCCGCRRGVCGCRVVCVGCGCV",
"student": "Charlie"
},
"expected": [
"violets",
"violets",
"clover",
"grass"
]
},
{
"uuid": "3ad3df57-dd98-46fc-9269-1877abf612aa",
"description": "for David",
"property": "plants",
"input": {
"diagram": "VRCGVVRVCGGCCGVRGCVCGCGV\nVRCCCGCRRGVCGCRVVCVGCGCV",
"student": "David"
},
"expected": [
"radishes",
"violets",
"clover",
"radishes"
]
},
{
"uuid": "0f0a55d1-9710-46ed-a0eb-399ba8c72db2",
"description": "for Eve",
"property": "plants",
"input": {
"diagram": "VRCGVVRVCGGCCGVRGCVCGCGV\nVRCCCGCRRGVCGCRVVCVGCGCV",
"student": "Eve"
},
"expected": [
"clover",
"grass",
"radishes",
"grass"
]
},
{
"uuid": "a7e80c90-b140-4ea1-aee3-f4625365c9a4",
"description": "for Fred",
"property": "plants",
"input": {
"diagram": "VRCGVVRVCGGCCGVRGCVCGCGV\nVRCCCGCRRGVCGCRVVCVGCGCV",
"student": "Fred"
},
"expected": [
"grass",
"clover",
"violets",
"clover"
]
},
{
"uuid": "9d94b273-2933-471b-86e8-dba68694c615",
"description": "for Ginny",
"property": "plants",
"input": {
"diagram": "VRCGVVRVCGGCCGVRGCVCGCGV\nVRCCCGCRRGVCGCRVVCVGCGCV",
"student": "Ginny"
},
"expected": [
"clover",
"grass",
"grass",
"clover"
]
},
{
"uuid": "f55bc6c2-ade8-4844-87c4-87196f1b7258",
"description": "for Harriet",
"property": "plants",
"input": {
"diagram": "VRCGVVRVCGGCCGVRGCVCGCGV\nVRCCCGCRRGVCGCRVVCVGCGCV",
"student": "Harriet"
},
"expected": [
"violets",
"radishes",
"radishes",
"violets"
]
},
{
"uuid": "759070a3-1bb1-4dd4-be2c-7cce1d7679ae",
"description": "for Ileana",
"property": "plants",
"input": {
"diagram": "VRCGVVRVCGGCCGVRGCVCGCGV\nVRCCCGCRRGVCGCRVVCVGCGCV",
"student": "Ileana"
},
"expected": [
"grass",
"clover",
"violets",
"clover"
]
},
{
"uuid": "78578123-2755-4d4a-9c7d-e985b8dda1c6",
"description": "for Joseph",
"property": "plants",
"input": {
"diagram": "VRCGVVRVCGGCCGVRGCVCGCGV\nVRCCCGCRRGVCGCRVVCVGCGCV",
"student": "Joseph"
},
"expected": [
"violets",
"clover",
"violets",
"grass"
]
},
{
"uuid": "6bb66df7-f433-41ab-aec2-3ead6e99f65b",
"description": "second to last student's garden",
"description": "for Kincaid, second to last student's garden",
"property": "plants",
"input": {
"diagram": "VRCGVVRVCGGCCGVRGCVCGCGV\nVRCCCGCRRGVCGCRVVCVGCGCV",
"student": "Kincaid"
},
"expected": ["grass", "clover", "clover", "grass"]
"expected": [
"grass",
"clover",
"clover",
"grass"
]
},
{
"uuid": "d7edec11-6488-418a-94e6-ed509e0fa7eb",
"description": "last student's garden",
"description": "for Larry, last student's garden",
"property": "plants",
"input": {
"diagram": "VRCGVVRVCGGCCGVRGCVCGCGV\nVRCCCGCRRGVCGCRVVCVGCGCV",
"student": "Larry"
},
"expected": ["grass", "violets", "clover", "violets"]
"expected": [
"grass",
"violets",
"clover",
"violets"
]
}
]
}
Expand Down