Skip to content

luhn: check a number with an even remainder #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2020
Merged

luhn: check a number with an even remainder #1635

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0754936
test(luhn): check a long number with an even remainder
Feb 8, 2020
ae0ce5b
fix(luhn): minor version bump instead of a patch
Feb 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion exercises/luhn/canonical-data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"exercise": "luhn",
"version": "1.6.1",
"version": "1.7.0",
"cases": [
{
"description": "single digit strings can not be valid",
Expand Down Expand Up @@ -58,6 +58,14 @@
},
"expected": false
},
{
"description": "invalid long number with an even remainder",
"property": "valid",
"input": {
"value": "1 2345 6789 1234 5678 9012"
},
"expected": false
},
{
"description": "valid number with an even number of digits",
"property": "valid",
Expand Down