Skip to content

resistor-color-duo: Fix wording in description, add test case #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

resistor-color-duo: Fix wording in description, add test case #1605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1b98a7
resistor-color-duo: Fix wording in description, add test case
sshine Oct 13, 2019
f26b31e
resistor-color-duo: Bump version number from 2.1.0 to 2.2.0
sshine Oct 13, 2019
82467aa
Revert 10 + 5 = 15 hint.
sshine Oct 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion exercises/resistor-color-duo/canonical-data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"exercise": "resistor-color-duo",
"version": "2.1.0",
"version": "2.2.0",
"cases": [
{
"description": "Brown and black",
Expand Down Expand Up @@ -34,6 +34,14 @@
},
"expected": 33
},
{
"description": "Black and brown",
"property": "value",
"input": {
"colors": ["black", "brown"]
},
"expected": 1
},
{
"description": "Ignore additional colors",
"property": "value",
Expand Down
8 changes: 4 additions & 4 deletions exercises/resistor-color-duo/description.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ If you want to build something using a Raspberry Pi, you'll probably use _resist

* Each resistor has a resistance value.
* Resistors are small - so small in fact that if you printed the resistance value on them, it would be hard to read.
To get around this problem, manufacturers print color-coded bands onto the resistors to denote their resistance values. Each band has a position and a numeric value. For example, if they printed a brown band (value 1) followed by a green band (value 5), it would translate to the number 15.

In this exercise you are going to create a helpful program so that you don't have to remember the values of the bands. The program will take color names as input and output a two digit number, even if the input is more than two colors!
To get around this problem, manufacturers print color-coded bands onto the resistors to denote their resistance values. Each band has a numeric and a positional value. For example, if they printed a brown band (value 1) followed by a green band (value 5), it would translate to the numeric value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "it would translate to the numeric value" would lead a reader to think "what numeric value?"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I felt the same way about "number". It should be more specific.


In this exercise you are going to create a helpful program so that you don't have to remember the numeric values of the bands. The program will take color names as input and output a numeric value of at most two digits.

The band colors are encoded as follows:

Expand All @@ -21,6 +21,6 @@ The band colors are encoded as follows:
- White: 9

From the example above:
brown-green should return 15
brown-green-violet should return 15 too, ignoring the third color.

- Brown and green should return 15.
- If your language track enables more than two colors as input, such as brown, green and violet, this should return 15, too, ignoring additional colors beyond the first two.