Skip to content

[Space Age] Put Earth in it's proper order #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 20, 2019
Merged

[Space Age] Put Earth in it's proper order #1573

merged 2 commits into from
Aug 20, 2019

Conversation

@joshgoebel
Copy link
Contributor

@joshgoebel joshgoebel commented Aug 20, 2019

  • Move Earth into its proper position in the solar system
  • Make wording more consistent

@joshgoebel
[Space Age] Put Earth in it's proper order
221a441 
- Move Earth into its proper position in the solar system
- Make wording more consistent
@joshgoebel joshgoebel mentioned this pull request Aug 20, 2019
Merged
SaschaMann
SaschaMann reviewed Aug 20, 2019
View reviewed changes
kotp
kotp requested changes Aug 20, 2019
View reviewed changes
yawpitch
yawpitch approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@yawpitch yawpitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With just the positional change I think this is fine. I tend to agree with no thousands delimiter.

@joshgoebel
Copy link
Contributor Author

joshgoebel commented Aug 20, 2019

The delimiter has been removed. :-)

@joshgoebel
Copy link
Contributor Author

joshgoebel commented Aug 20, 2019

Not sure why it's still blocked?

@kotp kotp merged commit ab56441 into exercism:master Aug 20, 2019
@SleeplessByte
Copy link
Member

SleeplessByte commented Aug 24, 2019

@yyyc514 It was blocked because @kotp had not yet switched his review. In general we wait for three ✅ on this repository before we merge.

@joshgoebel
Copy link
Contributor Author

joshgoebel commented Aug 24, 2019

Ah... I thought perhaps it'd auto-approve since I accepted his recommendation. I see he had to come back and manually review it again. Ok. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kotp kotp kotp approved these changes

@rpottsoh rpottsoh rpottsoh approved these changes

+2 more reviewers

@yawpitch yawpitch yawpitch approved these changes

@SaschaMann SaschaMann SaschaMann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joshgoebel @SleeplessByte @kotp @yawpitch @rpottsoh @SaschaMann