Skip to content

luhn: non-digit at end is invalid #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2018
Merged

luhn: non-digit at end is invalid #1420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion exercises/luhn/canonical-data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"exercise": "luhn",
"version": "1.3.0",
"version": "1.4.0",
"cases": [
{
"description": "single digit strings can not be valid",
Expand Down Expand Up @@ -74,6 +74,14 @@
},
"expected": false
},
{
"description": "valid strings with a non-digit added at the end become invalid",
"property": "valid",
"input": {
"value": "059a"
},
"expected": false
},
{
"description": "valid strings with punctuation included become invalid",
"property": "valid",
Expand Down