Skip to content

Conversation

@tmccombs
Copy link
Contributor

I encountered a solution that passed all provided test cases but would have failed this test.

Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sensible test, and seems to be placed in a reasonable location.

since submitter can merge, I'm assuming it's not my responsibility to merge

Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh hold on, increase the version number

@petertseng petertseng changed the title Add test case for exactly negative sixty minutes. clock: Add test case for exactly negative sixty minutes. Nov 18, 2018
@tmccombs
Copy link
Contributor Author

added

Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

because submitter can merge, I will assume that I don't need to do that

@petertseng
Copy link
Member

I added clock: to the PR title, I hope you can add it to the commit message before merging. So that it is possible to understand what exercise it refers to when just looking through git log

I encountered a solution that passed all provided test cases but would have failed this test.
@tmccombs tmccombs merged commit 2da517d into master Nov 19, 2018
@petertseng petertseng deleted the tmccombs-patch-1 branch November 19, 2018 04:00
sshine pushed a commit to exercism/haskell that referenced this pull request Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants