Skip to content

Conversation

@glennj
Copy link
Contributor

@glennj glennj commented Sep 30, 2021

Also adds an example solution to the exercise's yaml data.

Resolves #433

Also adds an example solution to the exercise's yaml data.

Resolves exercism#433
@glennj glennj changed the title This adds subtests for the sortedData test cases. binary-search-tree: perform tests for the sortedData test cases. Sep 30, 2021
@glennj
Copy link
Contributor Author

glennj commented Oct 8, 2021

@exercism/perl5 folks, can you take a look please?

Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursory peek, looks good to me.

@glennj
Copy link
Contributor Author

glennj commented Oct 8, 2021

I don't have the ability to add reviews to a PR in this repo. @kotp can you add any appropriate people/teams please?

@kotp kotp self-requested a review October 8, 2021 20:07
@kotp
Copy link
Member

kotp commented Oct 8, 2021

I do not have sufficient rights to add to teams @glennj So I think @ErikSchierboom would have to do so.

Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good to me.

@ErikSchierboom
Copy link
Member

I do not have sufficient rights to add to teams @glennj So I think @ErikSchierboom would have to do so.

Are you asking me to add @glennj to the perl5 team? Sorry if I'm being dense.

@SleeplessByte
Copy link
Member

@ErikSchierboom yes. Glenn would like to be able to Review PRs in this repo.

@ErikSchierboom
Copy link
Member

@SleeplessByte I just checked and it looks like I don't have permissions to do that. I'll defer to @iHiD when he's back.

@glennj
Copy link
Contributor Author

glennj commented Oct 11, 2021

What I'm lacking is the ability to add reviewers to a PR. Although it seems like this track is abandoned, in which case I should become a maintainer.

@SleeplessByte
Copy link
Member

(Meanwhile, I'll just merge this, ok?)

@SleeplessByte SleeplessByte merged commit 41f3042 into exercism:main Oct 11, 2021
@ErikSchierboom
Copy link
Member

What I'm lacking is the ability to add reviewers to a PR.

Yeah, you need to be added to the team for this, but I can't do that for you due to me not having the required permissions.

@glennj glennj deleted the binary-search-tree branch October 12, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

binary-search-tree tests are broken

4 participants