-
-
Notifications
You must be signed in to change notification settings - Fork 56
binary-search-tree: perform tests for the sortedData test cases.
#434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also adds an example solution to the exercise's yaml data. Resolves exercism#433
sortedData test cases.sortedData test cases.
|
@exercism/perl5 folks, can you take a look please? |
kotp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursory peek, looks good to me.
|
I don't have the ability to add reviews to a PR in this repo. @kotp can you add any appropriate people/teams please? |
|
I do not have sufficient rights to add to teams @glennj So I think @ErikSchierboom would have to do so. |
kotp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good to me.
Are you asking me to add @glennj to the perl5 team? Sorry if I'm being dense. |
|
@ErikSchierboom yes. Glenn would like to be able to Review PRs in this repo. |
|
@SleeplessByte I just checked and it looks like I don't have permissions to do that. I'll defer to @iHiD when he's back. |
|
What I'm lacking is the ability to add reviewers to a PR. Although it seems like this track is abandoned, in which case I should become a maintainer. |
|
(Meanwhile, I'll just merge this, ok?) |
Yeah, you need to be added to the team for this, but I can't do that for you due to me not having the required permissions. |
Also adds an example solution to the exercise's yaml data.
Resolves #433