✨ Add new exercise : Affine Cipher #887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomPradat
commented
Oct 29, 2020
TomPradat
commented
Oct 29, 2020
TomPradat
changed the title
config.json
Outdated
| "topics": [ | ||
| "graph_theory" | ||
| ] | ||
| }, |
Member
There was a problem hiding this comment.
I think this file is ordered. Or at least it was. It should be around the other unlocked_by simple-cipher, and then it's probably sorted by difficulty > lexographically.
SleeplessByte
approved these changes
Nov 2, 2020
Member
SleeplessByte
left a comment
SleeplessByte
left a comment
There was a problem hiding this comment.
2 nits :). Looking great @TomPradat
|
|
||
| export const decode = (phrase, key) => { | ||
| throw new Error("Remove this statement and implement this function"); | ||
| } No newline at end of file |
exercises/affine-cipher/example.js
Outdated
| @@ -0,0 +1,101 @@ | |||
| const ALPHABET = 'abcdefghijklmnopqrstuvwxyz'; | |||
| const m = ALPHABET.length; | |||
Member
There was a problem hiding this comment.
Can you uppercase this, and give it a name?
Member
|
You're on a roll! Are you on our maintainers list yet? Would you like to help out with v3? |
Contributor
Author
Idk if I'm on the maintainers list yet, i guess not. I've already started a PR to help with v3 and I'll be glad to help more 👍 |
ErikSchierboom
added
x:size/large
This was referenced Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #886