resolved issue #667 #711
Merged
resolved issue #667 #711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SleeplessByte
added
enhancement 🦄
Member
|
I love this @alirezaghey . Amazing work. The only thing I would like to change is: can you format the file like before? Each array item on their own line? Apart form that, this is perfect. I personally don't think Matrix is a datastructure "topic" -- could you remove it for now? We'll figure out a better topic and add it to ProblemSpec. |
Contributor
Author
|
Thanks @SleeplessByte. That's encouraging. Other than in Matrix, there or six other occurrences of data_structures in the file. |
Member
|
Nah, all of them. And let's open a new issue with those 7 that we have to see if there is an alternative! |
SleeplessByte
approved these changes
Aug 24, 2019
Member
|
Thank you for this contribution @alirezaghey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kept "data_structures" since I find it sensible.
Needs to be added to https://github.com/exercism/problem-specifications