Implement Connect Exercise #2027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sjoint-set data structure.
jmrunkle
suggested changes
Sep 24, 2021
Contributor
jmrunkle
left a comment
jmrunkle
left a comment
There was a problem hiding this comment.
Thanks for working on this!
exercises/practice/connect/.meta/src/reference/java/Connect.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the fedback @jmrunkle ! |
Use splitting on sentence break to reduce the splash radius as suggested. Co-authored-by: Jason Runkle <[email protected]>
Add trailing newline as suggested Co-authored-by: Jason Runkle <[email protected]>
…efine the UnionFind data structure in a class. We define a board and its methods. We then use them in providing a solution to the exercise.
Contributor
Author
|
@jmrunkle sorry for the delay. I did the necessary refactoring. Please could you have a look? |
jmrunkle
suggested changes
Oct 6, 2021
Update instructions Co-authored-by: Jason Runkle <[email protected]>
Contributor
Author
|
@jmrunkle please could you have a look again? |
jmrunkle
approved these changes
Oct 7, 2021
Contributor
jmrunkle
left a comment
jmrunkle
left a comment
There was a problem hiding this comment.
Just a couple minor comments then I can merge it, thanks for working on this!
Contributor
Author
I was about to apply the changes but thanks for the support! |
This was referenced Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull request
Closes #1743
Provide test, starter and reference implementations for the connect practice exercise
Reviewer Resources:
Track Policies