Skip to content

Conversation

@midyh
Copy link
Contributor

@midyh midyh commented Nov 6, 2021

Closes #187.

I wrote all (and removed some) of the current concepts. This will also fix the CI since the configlet requires all concept authors arrays to not be empty.

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit much to properly review in its entirety, but I've done a cursory review and this looks great. We can always improve things later on.

Comment on lines -243 to -246
"prerequisites": [
"basics",
"strings"
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove these prerequisites?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, it was for the CI I think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes precisely, it is for the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:size/massive Massive amount of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix CI

2 participants