robot-simulator: bump version to 3.2.0 and update test titles #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comparing the current tests (3.1.0.7) with the current canonical version for this exercise (3.2.0), the descriptions and titles have changed in the PR exercism/problem-specifications#1525
petertseng
approved these changes
Oct 15, 2019
Member
petertseng
left a comment
petertseng
left a comment
There was a problem hiding this comment.
Thank you for submitting this PR.
On my review, I confirmed that only the descriptions changed between 3.1.0 and 3.2.0. I admit that is a little unexpected since I usually associate a change from x.y.z to x.y+1.0 to change what is being tested, but that is a story for another day!
I'd like to give other maintainers about 48 hours to object.
sshine
approved these changes
Oct 17, 2019
petertseng
approved these changes
Oct 17, 2019
| coordinates (move robot inst) `shouldBe` (0, 0) | ||
|
|
||
| describe "turning right rotates the robot's direction 90 degrees clockwise" $ do | ||
| describe "Rotating clockwise" $ do |
Member
There was a problem hiding this comment.
This is more of a comment on the canonical data than this particular PR - it may not be obvious to students that right is clockwise and left is counter-clockwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing the current tests (3.1.0.7) with the current canonical
version for this exercise (3.2.0), the descriptions and titles have
changed in the PR exercism/problem-specifications#1525