Sync test leap 1.6.0 #857
Merged
Sync test leap 1.6.0 #857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshine
suggested changes
Oct 5, 2019
There was a problem hiding this comment.
Hi, and thanks for bumping the versions of leap and arm-strong-numbers!
It is nice to see that you have preserved the order of tests from problem-specifications, even though this was not requested.
If you don't mind, I'd like to split the bump of armstrong-numbers into its own PR.
I realize that you have already done this and that this makes rebasing easier. I'll merge them in the order they were submitted.
|
Just as in #856 (comment), I would think here it is possible to include a short summary in the commit message. "Add years that refute some unusual factors" seems suitable. |
sshine
approved these changes
Oct 5, 2019
sshine
force-pushed
the
sync-test-leap-1.6.0
branch
from
9f73642 to
716cc34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade leap to 1.6.0
added tests for exercism/problem-specifications#1581