Skip to content

Conversation

@norbs57
Copy link
Contributor

@norbs57 norbs57 commented Mar 25, 2022

Fixes #2038
Implements concept randomness including an exercise
The exercise was partly ported from the roll-a-die exercise on the C# track

@github-actions
Copy link
Contributor

Dear norbs57

Thank you for contributing to the Go track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • 📜 The following files usually contain very similar content.

    • concepts/<concept>/about.md
    • concepts/<concept>/introduction.md
    • exercises/concept/<exercise>/.docs/introduction.md

    Please check whether the changes you made to one of these also need to be applied to the others.

  • 🧦 If you changed the function signature or the function comment in the exemplar file or the stub file (<exercise>.go), make sure the change is applied to both files.

  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

@norbs57 norbs57 force-pushed the randomness branch 8 times, most recently from 47c4c58 to 96fe457 Compare March 25, 2022 22:37
Fixes exercism#2038

Implements concept randomness together with a concept exercise.

The exercise was partly ported from the roll-a-die exercise on the C# track.

Updated root-level config.json
Copy link
Member

@andrerfcsantos andrerfcsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. I really like the introduction to the subject you did, is short, straight to the point and the examples are relevant.

Left some minor comments.

@andrerfcsantos andrerfcsantos added x:size/large Large amount of work status/awaiting-contributor This pull request is waiting on the contributor. labels Mar 27, 2022
@norbs57
Copy link
Contributor Author

norbs57 commented Mar 28, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/awaiting-contributor This pull request is waiting on the contributor. x:size/large Large amount of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement new Concept Exercise: Randomness

2 participants