Fill in documentation for type-assertions
#1706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmrunkle
added
september-sprint
status/awaiting-maintainer
junedev
reviewed
Sep 28, 2021
junedev
added
status/awaiting-contributor
jmrunkle
added
status/awaiting-maintainer
Contributor
Author
|
Thanks @junedev - addressed your initial round of comments there. Not sure if we can be any more succinct than that about the type-switch without removing it from the intro completely, but I am open to suggestions. |
Member
|
I think it's fine as is. Can always be changed later someone feels the need for that. |
junedev
approved these changes
Sep 29, 2021
junedev
removed
the
status/awaiting-maintainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1703
Partially addresses #1704