Chessboard updates #1661
Merged
Chessboard updates #1661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is alredy covered in concepts/range-iteration/introduction.md and so, as it's not needed for the exercise it shouldn't be in the exercise. Fixes exercism#1604
This is a first crack at implementing the `type-definition` concept as proposed @junedev Updates chessboard to teach that type, and to remove mention of methods as these will come afterwards. This fixes exercism#1602. Fixes exercism#1603 by making it obsolete
junedev
approved these changes
Sep 20, 2021
Member
junedev
left a comment
junedev
left a comment
There was a problem hiding this comment.
The texts might need a little tweaking later but since this is a really big step in the right direction I am merging this as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to
chessboardexercise as per the tracking ticket for that exercise (#1623)Also adds
type-definitionsconcept as suggested by @junedev in #1602 and changes dependencies of exercises to accomadate.Fixes #1604. Fixes #1601. Fixes #1602. Fixes #1603 by making it obsolete. Fixes #1623.